Fix GH-15087 IntlChar::foldCase()'s $option is not optional #15091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since that parameter is supposed to be optional (and has been prior to PHP 8.0.0), we fix the implementation instead of the stub.
nielsdos
reviewed
Jul 24, 2024
deAtog
pushed a commit
to deAtog/php-src
that referenced
this pull request
Jul 26, 2024
Since that parameter is supposed to be optional (and has been prior to PHP 8.0.0), we fix the implementation instead of the stub. Closes phpGH-15091.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since that parameter is supposed to be optional (and has been prior to PHP 8.0.0), we fix the implementation instead of the stub.
Note that Windows CI is supposed to fail due to 0956267#r144587696. Locally, the intl tests were running fine.